Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convection-shmonvection #78697

Merged
merged 3 commits into from
Dec 21, 2024
Merged

Convection-shmonvection #78697

merged 3 commits into from
Dec 21, 2024
+56 −28

Conversation

Night-Pryanik
Copy link
Contributor

@Night-Pryanik Night-Pryanik commented Dec 21, 2024 •
edited
Loading

Summary

Bugfixes "Heat radiance now can spread through gas-permeable tiles like chain link fence"

Purpose of change

Describe the solution

  • Heat radiance now can spread through gas-permeable tiles. Previously it needed to pass a "clear_path between two points" check. Chain link fences obviously failed this check since they are not passable.
  • Added PERMEABLE flag to lots of terrain types that lacked it, like open palisade gate, open and closed wooden gate, or privacy fence.

Describe alternatives you've considered

None.

Testing

Threw molotov next to a chain link fence, stood next to it, checked temperature with a thermometer.

Also just in case replaced one piece of fence (right next to me) with a concrete wall, checked that temperature has fallen.

Additional context

изображение

изображение

PR title name taken from TVTropes.

@Night-Pryanik Night-Pryanik added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) Mechanics: Temperature Freezing, cooling, thawing, heating, etc. mechanics Mechanics: Character / Player Character / Player mechanics labels Dec 21, 2024
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 21, 2024
@Maleclypse Maleclypse merged commit aba1ffb into CleverRaven:master Dec 21, 2024
25 of 29 checks passed
@Night-Pryanik Night-Pryanik deleted the convection-shmonvection branch December 22, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Character / Player Character / Player mechanics Mechanics: Temperature Freezing, cooling, thawing, heating, etc. mechanics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

various fences blocks fields from spreading
2 participants
@Night-Pryanik @Maleclypse